fix: correct double swap of parameters in AnswerAccuracy metric templ… #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
@sahusiddharth Can u help with codestyle CI please? |
|
Hi @DmitrySirakov, can you the failing CI will pass if you just update your branch. |
|
Hi @sahusiddharth, I’ve synced my branch with upstream/main and pushed the updates, so the CI should now pass. |
sahusiddharth
requested review from
shahules786
and removed request for
sahusiddharth
|
Hi @shahules786, can u check this PR please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the double swap bug in the AnswerAccuracy metric implementation. In the original implementation, both the meta-labels (User Answer / Reference Answer) and their corresponding values (sample.response and sample.reference) were swapped, leading to an unintended behavior. According to the documentation, only the labels should be swapped while the values must remain in the original order.
Changes Made
sentence_inferenceas sample.response andsentence_trueas sample.reference in both prompts.Issue Reference
This fixes issue #2000.
Additional Notes
Please review the changes and let me know if further modifications are needed.